Skip to content

[feat](snapshot) clone instance return image url #56310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 24, 2025
Merged

[feat](snapshot) clone instance return image url #56310

merged 1 commit into from
Sep 24, 2025

Conversation

@mymeiyi
Copy link
Contributor

@mymeiyi mymeiyi commented Sep 22, 2025

What problem does this PR solve?

Issue Number: close #xxx

Related PR: #xxx

Problem Summary:

Release note

None

Check List (For Author)

  • Test

    • Regression test
    • Unit Test
    • Manual test (add detailed scripts or steps below)
    • No need to test or manual test. Explain why:
      • This is a refactor/code format and no logic has been changed.
      • Previous test can cover this change.
      • No code files have been changed.
      • Other reason

  • Behavior changed:

    • No.
    • Yes.

  • Does this need documentation?

    • No.
    • Yes.

Check List (For Reviewer who merge this PR)

  • Confirm the release note
  • Confirm test cases
  • Confirm document
  • Add branch pick label

@Thearas
Copy link
Contributor

Thearas commented Sep 22, 2025

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

dataroaring
dataroaring approved these changes Sep 22, 2025
View reviewed changes
Copy link
Contributor

@dataroaring dataroaring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

PR approved by at least one committer and no changes requested.

@github-actions github-actions bot added approved Indicates a PR has been approved by one committer. reviewed labels Sep 22, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 22, 2025

PR approved by anyone and no changes requested.

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 23, 2025

run buildall

@doris-robot
Copy link

doris-robot commented Sep 23, 2025

Cloud UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 83.80% (1541/1839)
Line Coverage 67.83% (27615/40715)
Region Coverage 68.21% (13590/19924)
Branch Coverage 58.49% (7251/12398)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

FE UT Coverage Report

Increment line coverage `` 🎉
Increment coverage report
Complete coverage report

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

BE UT Coverage Report

Increment line coverage 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 52.41% (17627/33636)
Line Coverage 37.63% (160053/425323)
Region Coverage 32.17% (121968/379128)
Branch Coverage 33.50% (53441/159504)

@hello-stephen
Copy link
Contributor

hello-stephen commented Sep 23, 2025

BE Regression && UT Coverage Report

Increment line coverage 100% (0/0) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 71.17% (23396/32875)
Line Coverage 57.57% (244341/424431)
Region Coverage 52.96% (203533/384302)
Branch Coverage 54.58% (87455/160241)

@mymeiyi
Copy link
Contributor Author

mymeiyi commented Sep 23, 2025

run performance

@dataroaring dataroaring merged commit 6aa8e6e into apache:master Sep 24, 2025
30 of 34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gavinchou gavinchou gavinchou approved these changes

@w41ter w41ter w41ter approved these changes

@dataroaring dataroaring dataroaring approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by one committer. cloud reviewed snapshot

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@mymeiyi @Thearas @doris-robot @hello-stephen @gavinchou @w41ter @dataroaring